Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change eth_getFilterLogs return from nil to empty logs #3688

Open
wants to merge 1 commit into
base: release/v0.6.1
Choose a base branch
from
Open

change eth_getFilterLogs return from nil to empty logs #3688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jsonrpc/endpoints_eth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,13 +490,13 @@ func (e *EthEndpoints) GetFilterChanges(filterID string) (interface{}, types.Err
func (e *EthEndpoints) GetFilterLogs(filterID string) (interface{}, types.Error) {
filter, err := e.storage.GetFilter(filterID)
if errors.Is(err, ErrNotFound) {
return nil, nil
return []types.Log{}, nil
} else if err != nil {
return RPCErrorResponse(types.DefaultErrorCode, "failed to get filter from storage", err, true)
}

if filter.Type != FilterTypeLog {
return nil, nil
return []types.Log{}, nil
}

filterParameters := filter.Parameters.(LogFilter)
Expand Down