-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix base fee calculation for pre-london fork #774
Conversation
We require contributors/corporates @sieniven to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
Block gas limit tests failing. |
We require contributors/corporates @sieniven to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
We require contributors/corporates @sieniven to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
We require contributors/corporates @sieniven to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
@revitteth Thanks for the review. Fixed the failing block gas limits test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won’t that allow txs with 0 gas fees to be sent to the network?
@mandrigin as discussed, this PR should not let that happen. As the chain is running on pre-london fork anyway and since the design of the txpool is designed for post-london fork, the correct behavior will be for all txs to be promoted to the pending pool from the baseFee pool. However, txs with low gas prices of below initial base fee are able to enter the pool but get stuck in the baseFee pool forever. This bug on the txpool to add a minimum price limit check is resolved in #803. The correct fixes will be to fork guard the base fee calculation function, and together with the fixes on #803, we should see the desired behavior in the pool while safeguarding against gasless txs. |
* Fix base fee calculation for pre-london fork * Fix EIP1559 tests * Fix fork height check
* Fix base fee calculation for pre-london fork * Fix EIP1559 tests * Fix fork height check
Summary