-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stage_baches): rpc resequence stop stage on unwind #1297
base: zkevm
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, but I see some strange behaviour in a local setup now. I have a local network with 3s block times and sometimes the RPC picks up 1 new block, sometimes it jumps 2 blocks. Looking at the terminals side by side there seems to be a pause in the RPC reacting to new data appearing in the stream. Maybe a sleep waiting too long somewhere or something along those lines?
@hexoscott I removed an unneeded sleep and now only one is left that is waiting 1s between checks for new block on the datastream. I ran locally a sequencer + rpc and it doesn't skip blocks for me. |
Awesome! Working perfectly now with no delay between sequencer and RPC |
No description provided.