Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stage_baches): rpc resequence stop stage on unwind #1297

Open
wants to merge 66 commits into
base: zkevm
Choose a base branch
from

Conversation

V-Staykov
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 8, 2024
Copy link

sonarcloud bot commented Oct 9, 2024

revitteth
revitteth previously approved these changes Oct 15, 2024
Copy link
Collaborator

@hexoscott hexoscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, but I see some strange behaviour in a local setup now. I have a local network with 3s block times and sometimes the RPC picks up 1 new block, sometimes it jumps 2 blocks. Looking at the terminals side by side there seems to be a pause in the RPC reacting to new data appearing in the stream. Maybe a sleep waiting too long somewhere or something along those lines?

zk/datastream/client/stream_client.go Show resolved Hide resolved
zk/datastream/client/stream_client.go Outdated Show resolved Hide resolved
zk/stages/test_utils.go Show resolved Hide resolved
@V-Staykov
Copy link
Collaborator Author

@hexoscott I removed an unneeded sleep and now only one is left that is waiting 1s between checks for new block on the datastream. I ran locally a sequencer + rpc and it doesn't skip blocks for me.

@hexoscott
Copy link
Collaborator

Awesome! Working perfectly now with no delay between sequencer and RPC

afa7789
afa7789 previously approved these changes Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants