This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 534
Extract BLS library used in polybft to a standalone package #1981
Merged
Stefan-Ethernal
merged 10 commits into
develop
from
EVM-861-remove-kriptology-dependency
Oct 31, 2023
Merged
Extract BLS library used in polybft to a standalone package #1981
Stefan-Ethernal
merged 10 commits into
develop
from
EVM-861-remove-kriptology-dependency
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
EVM-861-remove-kriptology-dependency
branch
from
October 13, 2023 15:44
4477516
to
3910247
Compare
Stefan-Ethernal
added
the
breaking change
Functionality that contains breaking changes
label
Oct 15, 2023
Stefan-Ethernal
changed the title
Remove kryptology library
Remove kryptology library for BLS keys
Oct 15, 2023
Stefan-Ethernal
changed the title
Remove kryptology library for BLS keys
Remove kryptology library that handles BLS curves
Oct 15, 2023
Stefan-Ethernal
changed the title
Remove kryptology library that handles BLS curves
Remove Oct 15, 2023
kryptology
library that handles BLS curves
Stefan-Ethernal
force-pushed
the
EVM-861-remove-kriptology-dependency
branch
3 times, most recently
from
October 16, 2023 18:36
33312d3
to
284a9e3
Compare
Stefan-Ethernal
changed the title
Remove
Remove Oct 17, 2023
kryptology
library that handles BLS curveskryptology
library for BLS signing
igorcrevar
reviewed
Oct 17, 2023
igorcrevar
reviewed
Oct 17, 2023
igorcrevar
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small remark, otherwise good
If this is not IBFT backwards compatible maybe IBFT can be removed at this point? |
We can discuss it and decide, I was thinking the same. However, I'd still prefer to have this PR merged (first), because:
Does it make sense? |
Stefan-Ethernal
force-pushed
the
EVM-861-remove-kriptology-dependency
branch
2 times, most recently
from
October 18, 2023 06:28
98fca7d
to
52365b9
Compare
dusan-maksimovic
approved these changes
Oct 18, 2023
Stefan-Ethernal
added
the
don't merge
Please don't merge this functionality temporarily
label
Oct 18, 2023
stana-miric
approved these changes
Oct 19, 2023
Stefan-Ethernal
changed the title
Remove
Extract BLS library used in polybft to a standalone package
Oct 26, 2023
kryptology
library for BLS signing
Stefan-Ethernal
force-pushed
the
EVM-861-remove-kriptology-dependency
branch
from
October 26, 2023 10:10
52365b9
to
d1baa1d
Compare
goran-ethernal
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking change
Functionality that contains breaking changes
don't merge
Please don't merge this functionality temporarily
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts bls signing abstractions already used for
polybft
consensus protocol, which relies on this library https://github.com/umbracle/go-eth-bn256 to Edge standalone package.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it