-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update local-deployment.md with PP config #2486
Update local-deployment.md with PP config #2486
Conversation
Update doc and especify how to PP chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vcastellm Overall it looks good, can you make the following changes please:
- The system requirements and instructions are different between the PP and FEP local deployment right?
- Therefore, within the navigation we will need both the FEP and PP local deployment guides
- Instead of updating the existing file, can you create a new file titled "Pessimistic proofs (PP) guide"
- Update the existing file to be titled "Full execution proofs (FEP) guide"
- Nest both of these guides under the "Local deployment guide" navigation section
No, system requirements are the same for both, same for Kurtosis.
Given that the differences are minimal, IMO splitting them in different sections would create a lot of duplication. Generally, our goal in CDK and in DevTools is to provide users with something that's super easy to use, ideally it should be a one-liner to run the stack, therefore the changes in the document are minimal. That would create a 98% duplicated documents, I think it doesn't makes sense to artificially create 2 different documents. I wanted to be more explicit on the configuration doc but we can come up with 2 one-liners for each path: PP
FEP
|
@mitchpolygon I added the oneliners to a new section in the doc called: "Quick setup" that should be the super easy setup process for lazy people, the rest of the document is more detailed setup for curious people. |
|
||
### Pesimistic Proof | ||
|
||
kurtosis run --enclave cdk --args-file "https://raw.githubusercontent.com/0xPolygon/kurtosis-cdk/refs/heads/main/.github/tests/fork12-pessimistic.yml" github.com/0xPolygon/kurtosis-cdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to set a verision tag or commit hash to future proof against refactors. this would be need both for the args file and for the selector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is even temporary until the release, because it's going to be moved most prob.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Update doc and specify how to PP chain