Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: CDK PP - High Level Architecture doc #2462

Merged
merged 2 commits into from
Nov 20, 2024
Merged

DRAFT: CDK PP - High Level Architecture doc #2462

merged 2 commits into from
Nov 20, 2024

Conversation

EmpieichO
Copy link
Contributor

DRAFT: CDK PP - Add high level architecture doc

@EmpieichO EmpieichO changed the title DRAFT: CDK PP - Add high level architecture doc DRAFT: CDK PP - High level architecture doc Oct 24, 2024
@EmpieichO EmpieichO changed the title DRAFT: CDK PP - High level architecture doc DRAFT: CDK PP - High Level Architecture doc Oct 24, 2024
@EmpieichO EmpieichO mentioned this pull request Oct 24, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sharonbc01
Sharonbc01 reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@Sharonbc01 Sharonbc01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anthony, I really like the look of the diagram. Do we need to update the FEP diagram to match the style so we are consistent?

@vcastellm vcastellm marked this pull request as draft October 30, 2024 17:40
@mitchpolygon mitchpolygon marked this pull request as ready for review November 20, 2024 14:26
@mitchpolygon mitchpolygon merged commit cb73642 into main Nov 20, 2024
2 checks passed
@mitchpolygon mitchpolygon deleted the cdk-pp-highlevel-architecture branch November 20, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharonbc01 Sharonbc01 Sharonbc01 left review comments

@mitchpolygon mitchpolygon mitchpolygon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmpieichO @Sharonbc01 @mitchpolygon