Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding an option for call-data-file #474

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

praetoriansentry
Copy link
Member

The idea here is to to support large calldata where the input comes from a file rather than needing to be read as a argument. E.g

polycli ulxly bridge message \
--private-key $pkey \
--rpc-url  http://127.0.0.1:18546 \
--bridge-address 0x1348947e282138d8f377b467F7D9c2EB0F335d1f \
--destination-network 23 \
--value 0 \
--call-data-file <(xxd -p /dev/random | tr -d "\n" | head -c 261569)

The idea here is to to support large calldata where the input comes
from a file rather than needing to be read as a argument. E.g

```
polycli ulxly bridge message \
--private-key $pkey \
--rpc-url  http://127.0.0.1:18546 \
--bridge-address 0x1348947e282138d8f377b467F7D9c2EB0F335d1f \
--destination-network 23 \
--value 0 \
--call-data-file <(xxd -p /dev/random | tr -d "\n" | head -c 261569)
```
This reverts commit aebc9ed.
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leovct leovct merged commit 55b2659 into main Jan 14, 2025
6 checks passed
@leovct leovct deleted the jhilliard/calldata-file-option branch January 14, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants