Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BLAKE2 precompile address in LoadTester contract #432

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Nov 12, 2024

Description

Closes #430

Fix typo in BLAKE2 precompile address.

For reference: https://eips.ethereum.org/EIPS/eip-152

Jira / Linear Tickets

x

Testing

x

@leovct leovct changed the title fix: blake2f precompile address fix: BLAKE2 precompile address in LoadTester contract Nov 12, 2024
@leovct leovct enabled auto-merge (squash) November 13, 2024 09:15
@leovct leovct merged commit 3641488 into 0xPolygon:main Nov 13, 2024
6 checks passed
@leovct leovct deleted the fix/blake2f-precompile-address branch November 13, 2024 09:15
@doutv
Copy link
Contributor

doutv commented Nov 13, 2024

@leovct This PR doesn't fix the problem

Blake2f input should be different from the ECPairing input. You need to check the definition

Run loadtest --mode pr will get error

7:02PM TRC Executing contract method method=TestBlake2f
7:02PM ERR Recorded an error while sending transactions error="execution reverted" nonce=383807 request time=3

@leovct
Copy link
Member Author

leovct commented Nov 13, 2024

@leovct This PR doesn't fix the problem

Blake2f input should be different from the ECPairing input. You need to check the definition

Run loadtest --mode pr will get error

7:02PM TRC Executing contract method method=TestBlake2f
7:02PM ERR Recorded an error while sending transactions error="execution reverted" nonce=383807 request time=3

Thanks for pointing that out, I didn't check the implementation, my bad. It should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loadtest solidity: wrong blake2f precompile
3 participants