Added: Slither[arbitrary from in transferFrom] rule | #61 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKitsune
reviewed
Feb 11, 2023
|
|
||
| use crate::analyzer::ast::{self, Target}; | ||
|
|
||
| pub fn _arbitrary_from_in_transferfrom_vulnerability(source_unit: SourceUnit) -> HashSet<Loc> { |
There was a problem hiding this comment.
Can you remove the leading _ from the function name?
| ast::extract_target_from_node(Target::FunctionDefinition, source_unit.into()); | ||
|
|
||
| //For each target node that was extracted, check for the vulnerability patterns | ||
| for _node in target_nodes { |
There was a problem hiding this comment.
Can you remove the _ in front of the _node since node is being used?
| } = box_fn_definition.body.unwrap() | ||
| { | ||
| // We loop through each body expression to determine if 'transferFrom/SafeTransferFrom' is used. | ||
| for _statement in statements { |
There was a problem hiding this comment.
Same thing here, can you remove the _ in front of _statement?
|
Thanks for opening this PR! Just a few comments above. |
dijkstra-dev
force-pushed
the
arbitrary-from-in-transferfrom
branch
from
851cb1e to
5dd699f
Compare
|
Hey thanks for updating this PR as well, will get this reviewed and merged in. |
dijkstra-dev
force-pushed
the
arbitrary-from-in-transferfrom
branch
from
5dd699f to
c4b01e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #61