-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial docs #9
Initial docs #9
Conversation
"""Follow most links within the domain of URL in an attempt to discover and | ||
extract as many products as possible.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to use Foo.bar.__doc__
in enumMeta
to avoid duplication, but the __doc__
is not generated at regular run time (there’s some “interactive” condition in the decorator implementation), and this way we can potentially provide more details in the reference docs than those we want in enumMeta; maybe we could even make enumMeta provide a link to the upstream reference for details where needed.
|
||
* ``EcommerceSpider``: a spider that can scrape products from any e-commerce | ||
website. | ||
* Documentation: https://zyte-spider-templates.readthedocs.io/en/latest/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞 No one steals it.
|
||
.. autoenum:: zyte_spider_templates.spiders.ecommerce.EcommerceCrawlStrategy | ||
|
||
.. autoenum:: zyte_spider_templates.spiders.ecommerce.ExtractFrom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my rendering, I do not get “An enumeration.”, but rather nothing at all. Which I think is fine given the parameter descriptions themselves at the top. No strong opinion, though.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 98.08% 98.56% +0.47%
==========================================
Files 8 9 +1
Lines 471 488 +17
==========================================
+ Hits 462 481 +19
+ Misses 9 7 -2
|
No description provided.