-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add organization: url: attempt to autocomplete with zulipchat.com #1012
Comments
The android app already does this. Just FYI. |
Thanks for the feedback! Yeah, I'd like to see this changed in the desktop app as well. We should be smart about the UX details around this though -- we want to make it very clear what URL users will be connecting to if they submit the form. One possible option would be to have two text boxes, with the top one being (I don't think the Android app's exact implementation on this is particularly good) |
It make sense to autocomplete the url in the mobile app but in the desktop app, we should try to keep it as simple as possible. Don't need to add too much autocompletion and all. I think having two views (Self-hosted, zulipchat.com) would make sense here. |
UX? One box, if the current text input matches the conditions, show |
Yeah, I think that's better. We can assume |
I think some selfhosted folks could have something like |
As I mentioned before: With http, you would need to type How is this exactly handled in the mobile app? Did we miss something? |
Autocompletes when the user passes only org url, in the server url input. Fixes zulip#1012
Are you still working on this? @aryanshridhar |
Hey @Signior-X , I have already added the necessary changes within #1043 . Would be great if you could address something which I accidentally left out . |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Any chance I could take this a little further? I built off of #1043 and added a UX similar to the one's found in the mobile apps Here is what it could look like: let me know and I'll make a new PR for this issue |
@zulipbot claim |
Welcome to Zulip, @manila! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
Autocompletes when the user passes only org url, in the server url input. Fixes zulip#1012
@manila We noticed that you have not made any updates to this issue or linked PRs for 10 days. Please comment here if you are still actively working on it. Otherwise, we'd appreciate a quick If we don't hear back, you will be automatically unassigned in 4 days. Thanks! |
It looks like this could still be up for discussion so I'll remove myself from this issue. There is likely a better solution for this, and if this continues to remain open I may take another shot at it :) |
@zulipbot abandon |
Autocompletes when the user passes only org url, in the server url input. Fixes zulip#1012
Autocompletes when the user passes only org url, in the server url input. Fixes zulip#1012
Autocompletes when the user passes only org url, in the server url input. Fixes zulip#1012
is this issue still unresolved? |
Problem Description
Expected: overnode.zulipchat.org
Proposed Solution
If the entered string does:
If the URL will be autocompleted, Show that within the text box (with grey text?).
Describe alternatives you've considered
Give the user a first time impression of ERROR?
I might attempt to close this myself within tommorow - 3 months
The text was updated successfully, but these errors were encountered: