Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Error "Use of uninitialized value $CleanupSuccess" on SQL db communication error #632

Open
pboguslawski opened this issue Jan 27, 2025 · 0 comments

Comments

@pboguslawski
Copy link
Contributor

Sometimes, when SQL db communication error occurs, otrs.Daemon.pl generaters errors like

ERROR: OTRS-otrs.Daemon.pl - Daemon Kernel::System::Daemon::DaemonModules::SystemConfigurationSyncManager-1 Perl: 5.32.1 OS: linux Time: Mon Jan 27 15:53:27 2025

 Message: There was an error executing ConfigurationDeploySync: Use of uninitialized value $CleanupSuccess in numeric ne (!=) at /opt/otrs/Kernel/System/SysConfig.pm line 3735.

ERROR: OTRS-otrs.Daemon.pl - Daemon Kernel::System::Daemon::DaemonModules::SystemConfigurationSyncManager-1 Perl: 5.32.1 OS: linux Time: Mon Jan 27 15:53:27 2025

 Message: There are invalid deployments in the database that could not be removed!
 
 Traceback (19179):
   Module: Kernel::System::SysConfig::ConfigurationDeploySync Line: 3736
   Module: (eval) Line: 130
   Module: Kernel::System::Daemon::DaemonModules::SystemConfigurationSyncManager::Run Line: 117
   Module: (eval) Line: 332
   Module: main::Start Line: 332
   Module: /opt/otrs/bin/otrs.Daemon.pl Line: 153



 Traceback (19179):
   Module: Kernel::System::Daemon::DaemonModules::BaseTaskWorker::_HandleError Line: 53
   Module: Kernel::System::Daemon::DaemonModules::SystemConfigurationSyncManager::Run Line: 136
   Module: (eval) Line: 332
   Module: main::Start Line: 332
   Module: /opt/otrs/bin/otrs.Daemon.pl Line: 153

in SystemConfigurationSyncManagerERR.log.

Environment

  • Server OS: Debian 12
  • Browser: any
  • Znuny version: 6.5.11

Expected behavior

ConfigurationDeploySync should handle SQL connection problems signalized by DeploymentListCleanup correctly.

Actual behavior

$CleanupSuccess is uninitialized on db communication error and ConfigurationDeploySync does not handle this scenario correctly.

How to reproduce

Steps to reproduce the behavior:

  1. Insert return; before
    return if !$DBObject->Prepare(
    to simulate db connection problem and see daemon error log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant