Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proble Please check your options for splitby_key and your celltypes. #91

Open
dd123456000 opened this issue Dec 14, 2023 · 11 comments · Fixed by #97
Open

proble Please check your options for splitby_key and your celltypes. #91

dd123456000 opened this issue Dec 14, 2023 · 11 comments · Fixed by #97
Labels
bug Something isn't working

Comments

@dd123456000
Copy link

I encountered the following issue while using plotcb.

image

image

I've tried changing many things, but I'm still getting the same error.

@dd123456000
Copy link
Author

image

@dd123456000
Copy link
Author

image

image

@dd123456000
Copy link
Author

"I changed 'celltype' to 'cell_type,' and now I'm encountering the error 'Error in c_type1[[i]]: subscript out of bounds.'"

@zktuong
Copy link
Owner

zktuong commented Dec 14, 2023

Does the "celltype" or "cell_type" exist in your [email protected]? Also remove the the split.by argument - don't provide NA to it.

@luostrowski
Copy link

I'm having the same problem. The "predicted" column exists in the object (ad is a SingleCellExperiment object).

plot_cpdb2(
    scdata = ad,
    cell_type1 = "HSC",
    cell_type2 = ".",
    celltype_key = "predicted", # column name where the cell ids are located in the metadata
    means = means,
    pvals = pvals,
    deconvoluted = HD_deconv 
)

Error in plot_cpdb(scdata = scdata, cell_type1 = cell_type1, cell_type2 = cell_type2, :
Please check your options for splitby_key and your celltypes.

@zktuong
Copy link
Owner

zktuong commented Jan 9, 2024

hi @luostrowski, just in case, can you check if the means and pvals are the correct ones that match to your ad object. when library(ktplots) is called, it will also load the internal data (also called means and pvals). this may overwrite your actual objects.

@luostrowski
Copy link

Hi! Thank you for the prompt reply!
I changed the names of the data frames to make sure it was not being overwritten, but I got the same error :(

plot_cpdb2(
    scdata = ad,
    cell_type1 = "HSC",
    cell_type2 = ".",
    celltype_key = "predicted", # column name where the cell ids are located in the metadata
    means = HD_means,
    pvals = HD_pvals,
    deconvoluted = HD_deconv
)

Error in plot_cpdb(scdata = scdata, cell_type1 = cell_type1, cell_type2 = cell_type2, :
Please check your options for splitby_key and your celltypes.

@zktuong
Copy link
Owner

zktuong commented Jan 10, 2024

would you be able to share your files (ad, HD_means, HD_pvals, HD_deconv) so that i can do some testing? I just sent you the secure voucher link via filesender (to your gmail)

@zktuong
Copy link
Owner

zktuong commented Jan 10, 2024

issue may be related to zktuong/ktplotspy#51

@zktuong
Copy link
Owner

zktuong commented Feb 15, 2024

seems like the fix introduces further bugs (e.g. plotting non-significant interactions). need to think of a different solution

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 22, 2024
@zktuong zktuong removed the wontfix This will not be worked on label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants