You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
and they seem to be doing the same thing, almost. There's no documentation and I don't remember why I wrote them like this. It would be helpful if someone can investigate why we have two functions here, and either merge them into one or document why we need two different functions
The text was updated successfully, but these errors were encountered:
Hi @mimoo , this is my first issue on Noname so I may have some misunderstandings about the code.
From my understanding these are the differences:
match_expected: Allows for flexible matching between types, meaning it considers types equivalent in certain contexts, such as treating BigInt as equivalent to Field.
same_as: Requires an exact match between types, ensuring that two types are completely identical.
Should I try and use one of the 2 functions, or add docs that explains the difference?
I think a PR merging both of the functionality with some documentation and a new argument flag that allows switching between the two behaviors would be nice!
we have two functions:
and they seem to be doing the same thing, almost. There's no documentation and I don't remember why I wrote them like this. It would be helpful if someone can investigate why we have two functions here, and either merge them into one or document why we need two different functions
The text was updated successfully, but these errors were encountered: