Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Ruby 3.2 #507

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Add Support for Ruby 3.2 #507

merged 3 commits into from
Apr 25, 2024

Conversation

nicolaa
Copy link
Contributor

@nicolaa nicolaa commented Jan 13, 2023

Copy link

@cickes cickes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a beneficial update. The project benefits greatly by pushing this one out.

Notably, the version number would need a new MAJOR version.
Semantic versioning

@schm
Copy link

schm commented Apr 14, 2023

@nicolaa Thanks for the contribution. I hope this gets merged eventually.

Notably, the version number would need a new MAJOR version.

@cickes I don't think so. File.exist? is part of the core library since well before 2.0.0. https://ruby-doc.org/core-1.8.6/File.html#method-c-exist-3F So this change is in no way backwards incompatible.

@bf4
Copy link
Contributor

bf4 commented Jun 14, 2023

Looks like maybe https://github.com/stitchfix/rspec_api_documentation is the active fork to follow?

@santib
Copy link

santib commented Sep 8, 2023

@oestrich @jakehow what's the maintenance status of this gem? Are you looking for new maintainers? It'd be quite important to get this trivial PR merged 😬

Thanks 🙌

@apotema
Copy link

apotema commented Dec 1, 2023

@oestrich @jakehow could you please accept this PR

@bf4
Copy link
Contributor

bf4 commented Apr 19, 2024

We just upgraded to Ruby 3.3.0
We'll be building off the https://github.com/stitchfix/rspec_api_documentation fork for now but might start our own or transition to rspec-openapi and rswag like others have

@vladveterok
Copy link

vladveterok commented Apr 23, 2024

Hey good fellas, is there a good reason this PR is still not being merged?
If the project is dead (which is a possibility considering the date of the last change made) no further questions will be asked :)
Thanks!
cc @oestrich @jakehow

@bf4
Copy link
Contributor

bf4 commented Apr 23, 2024

Project needs to be adopted

@santib
Copy link

santib commented Apr 23, 2024

FWIW in https://github.com/rootstrap/rails_api_base we migrated to:

More info in https://github.com/rootstrap/rails_api_base/blob/main/docs/api_documentation.md

@apotema
Copy link

apotema commented Apr 23, 2024

These are some great libs @santib . But it would be good to have this lib back.

@jakehow
Copy link
Member

jakehow commented Apr 23, 2024

@vladveterok @bf4 lots of requests for maintenance and little volunteering to do it... I don't think this PR passed travisCI originally which is why it was not merged quickly. Travis now requires payment even on free plan which is probably why it's been removed. I am not sure if there is an alternative these days for OSS CI builds that is still free.

Happy to add anyone who wants to push some of these items forward ... @bf4 ?

@bf4
Copy link
Contributor

bf4 commented Apr 23, 2024

@jakehow Sure. I'll make a github actions test matrix pr on Wednesday if no one else has yet. (I'm afk right now)

@bf4 bf4 merged commit 6c6f651 into zipmark:master Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants