Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited INFO logging during rebalance #1405

Open
erikvanoosten opened this issue Nov 24, 2024 · 2 comments
Open

Limited INFO logging during rebalance #1405

erikvanoosten opened this issue Nov 24, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@erikvanoosten
Copy link
Collaborator

We have some very nice logging statements that could give insight when a rebalance goes wrong. However, because of the frequency and size of the logging, we currently log it at the DEBUG level. (See #1375 (comment).)

We would like to log this information at the INFO level, but not too often. For example, only after 3 seconds since the start of the rebalance, and then once every 3 seconds.

@lemony312
Copy link

The code has changed slighlty since this issue was opened - is this still a valid issue to address?

@erikvanoosten
Copy link
Collaborator Author

The code has changed slighlty since this issue was opened - is this still a valid issue to address?

Thanks for checking. Yes, IMHO this is still relevant. In particular for this logging statement:

ZIO.logDebug(
s"Delaying rebalance until ${streamsToEnd.size} streams (of revoked partitions) have committed " +
s"the offsets of the records they consumed. Deadline in ${timeToDeadlineMillis()}ms. $statusStrings"
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants