Skip to content

Remove legacy hardcoded attributes for lumi.airrtc.agl001 (Aqara E1 TRV) #620

@cl445

Description

@cl445

Summary

The manufacturerspecific.py file contains hardcoded ZCL_INIT_ATTRS for lumi.airrtc.agl001 (Aqara E1 TRV) that creates duplicate entities when used alongside the quirk in zha-device-handlers.

Location

zha/zigbee/cluster_handlers/manufacturerspecific.py lines ~128-141:

elif self.cluster.endpoint.model == "lumi.airrtc.agl001":
    self.ZCL_INIT_ATTRS = {
        "system_mode": True,
        "preset": True,
        "window_detection": True,
        "valve_detection": True,
        "valve_alarm": True,
        "child_lock": True,
        "away_preset_temperature": True,
        "window_open": True,
        "calibrated": True,
        "schedule": True,
        "sensor": True,
    }

Problem

Users see duplicate entities:

  • Legacy entities created by this hardcoded config (German translations from HA core)
  • Quirk-defined entities from zha-device-handlers (English names from quirk)

Proposed Solution

Remove this elif block once the improved quirk is merged in zigpy/zha-device-handlers#4604.

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions