You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am fixing a bug that caused by retain cycle between ECSignalingChannel and ECClient.
I found streamSignalingDelegates retain ECClient strongly in NSMutableDictionary from, so it has retain cycle. Should we avoid this retain cycle since subscribeClient and publish client should be released if needed after disconnection?
The text was updated successfully, but these errors were encountered:
Hi Li Lin, I am not able to work on it right now, if you want to submit PR
please go ahead.
El lun., 7 de ene. de 2019 a la(s) 00:46, Li Lin ([email protected])
escribió:
I am fixing a bug that caused by retain cycle between ECSignalingChannel
and ECClient.
I found streamSignalingDelegates retain ECClient strongly in
NSMutableDictionary from, so it has retain cycle. Should we avoid this
retain cycle since subscribeClient and publish client should be released if
needed after disconnection?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#85>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACgaueUty5oxD7tZnjr-NX7f0lMiM32ks5vAsMAgaJpZM4Zy0S5>
.
I am fixing a bug that caused by retain cycle between
ECSignalingChannel
andECClient
.I found
streamSignalingDelegates
retainECClient
strongly in NSMutableDictionary from, so it has retain cycle. Should we avoid this retain cycle since subscribeClient and publish client should be released if needed after disconnection?The text was updated successfully, but these errors were encountered: