soc: espressif: minimal runtime heap size request #81780
Draft
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce config option to make sure enough space will be available for the runtime heap. Signed-off-by: Marek Matej <[email protected]>
kartben
reviewed
Nov 22, 2024
Comment on lines
+39
to
+41
| Ask for reserved space at the end of DRAM. Not having this minimal size could pottentionaly | ||
| lead to statically allocate all of available DRAM, not having enough for the subsystems | ||
| which depends on ESP_HEAP_RUNTIME (such as WiFi or BT). |
There was a problem hiding this comment.
Suggested change
| Ask for reserved space at the end of DRAM. Not having this minimal size could pottentionaly | |
| lead to statically allocate all of available DRAM, not having enough for the subsystems | |
| which depends on ESP_HEAP_RUNTIME (such as WiFi or BT). | |
| Ask for reserved space at the end of DRAM. Not having this minimal size could potentially | |
| lead to statically allocating all of available DRAM, not having enough for the subsystems | |
| which depends on ESP_HEAP_RUNTIME (such as WiFi or BT). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce config option to make sure enough space will be available for the runtime heap.