Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

board mps3_corstone300_fvp_ns fetching code from external repositories and failing in CI #81656

Open
nashif opened this issue Nov 20, 2024 · 1 comment · May be fixed by #83360
Open

board mps3_corstone300_fvp_ns fetching code from external repositories and failing in CI #81656

nashif opened this issue Nov 20, 2024 · 1 comment · May be fixed by #83360
Assignees
@ithinuel
Labels
area: ARM ARM (32-bit) Architecture bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug

Comments

@nashif
Copy link
Member

nashif commented Nov 20, 2024

Describe the bug

New board fetching code from external repositories in violation of zephyr rules and causing build issues in CI:

-- Build files have been written to: /__w/zephyr/zephyr/twister-out/mps3_corstone300_fvp_ns/samples/psa/persistent_key/sample.psa.persistent_key.tfm/tfm/lib/ext/ethos_u_core_driver-subbuild
[1/9] Creating directories for 'ethos_u_core_driver-populate'
[1/9] Performing download step (git clone) for 'ethos_u_core_driver-populate'
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': The requested URL returned error: 503
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': The requested URL returned error: 503
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': The requested URL returned error: 503
-- Had to git clone more than once:
3 times.
CMake Error at ethos_u_core_driver-subbuild/ethos_u_core_driver-populate-prefix/tmp/ethos_u_core_driver-populate-gitclone.cmake:31 (message):
Failed to clone repository:
'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver'

To Reproduce

https://github.com/zephyrproject-rtos/zephyr/actions/runs/11929471451/job/33248728397?pr=79931

Expected behavior

Builds and no dependency on external sources

Impact

Violation of zephyr project rules and CI failures.

Logs and console output

https://github.com/zephyrproject-rtos/zephyr/actions/runs/11929471451/job/33248728397?pr=79931
@nashif nashif added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug area: ARM ARM (32-bit) Architecture labels Nov 20, 2024
@nashif nashif mentioned this issue Nov 20, 2024
Merged
nashif added a commit to nashif/zephyr that referenced this issue Nov 20, 2024
@nashif
boards: mps3_corstone300_fvp_ns: disable twister
2105c24 
Disable board temporarily as it fetches code from external repositories.

Related issue zephyrproject-rtos#81656

Signed-off-by: Anas Nashif <[email protected]>
nashif added a commit that referenced this issue Nov 20, 2024
@nashif
boards: mps3_corstone300_fvp_ns: disable twister
1c596b8 
Disable board temporarily as it fetches code from external repositories.

Related issue #81656

Signed-off-by: Anas Nashif <[email protected]>
@jhedberg jhedberg mentioned this issue Nov 20, 2024
Closed
@ithinuel
Copy link
Collaborator

ithinuel commented Nov 20, 2024 •
edited
Loading

So, if I understand correctly, this is a violation of the "no fetch during build time" from TF-M: https://github.com/zephyrproject-rtos/trusted-firmware-m/blob/8134106ef9cb3df60e8bd22b172532558e936bd2/lib/ext/ethos_u_core_driver/CMakeLists.txt, right?

@khoa-nguyen-18 khoa-nguyen-18 mentioned this issue Nov 25, 2024
Merged
@wearyzen wearyzen linked a pull request Dec 24, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ithinuel ithinuel

Labels
area: ARM ARM (32-bit) Architecture bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modules: avoid fetching external repo in TF-M wearyzen/zephyr
2 participants
@nashif @ithinuel