lib: os: mpsc_pbuf: do not use sem when spinlock is held #83355
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging in spinlock context when the log buffer is full can lead to taking the branch that attempts to wait for a sem, this causes a context switch which isn't allowed when a spinlock is held. Which may trigger an 'ASSERTION FAILED' message (when `CONFIG_SPIN_VALIDATE=y`) which is again, routed through the logging subsystem (when `CONFIG_LOG=y`), and since the log buffer was already full, this just goes on and on and on forever. To prevent that, check if the current spinlock key can be used to unlock IRQ, if it doesn't, it means that a lock is already held outside the function. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Maxim Adelman <[email protected]>
ycsin
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging in spinlock context when the log buffer is full can lead to taking the branch that attempts to wait for a sem, this causes a context switch which isn't allowed when a spinlock is held. Which may trigger an 'ASSERTION FAILED' message
(when
CONFIG_SPIN_VALIDATE=y) which is again, routed through the logging subsystem (whenCONFIG_LOG=y), and since the log buffer was already full, this just goes on and on and on forever.To prevent that, check if the current spinlock key can be used to unlock IRQ, if it doesn't, it means that a lock is already held outside the function.