Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redunding command #16

Closed
Raphael-Boichot opened this issue Jun 6, 2022 · 1 comment
Closed

Redunding command #16

Raphael-Boichot opened this issue Jun 6, 2022 · 1 comment
Labels
NeoGBP bug Something in our code isn't working

Comments

@Raphael-Boichot
Copy link
Collaborator

This commands in config.h.txt
#define BMP_UPSCALE_FACTOR 1 //Set the Upscale factor for the BMP output (Set 0 to disable)
#define PNG_UPSCALE_FACTOR 1 //Set the Upscale factor for the PNG output (Set 0 to disable)

Is redunding with:

"bmpimage": {
"scale":1
},
"pngimage": {
"scale":1
}

In conf.json

@Raphael-Boichot Raphael-Boichot added the NeoGBP bug Something in our code isn't working label Jun 6, 2022
@zenaro147
Copy link
Owner

@Raphael-Boichot Technically, no. (at least in my head)

the config.h will be used as default value in the NeoGBP. So, especially if the conf.json doesn't exist, the NeoGBP will create the conf.json based in the config.h values at first time.

The conf.json parameters are fully customizable and will replace the config.h values. The idea is prevent to re-upload the arduino code for each change.

for example: if one day you just want to output as PNG only, for example, you just need to set the bmpimage>scale to 0 in the conf.json, instead upload the whole code again. the same idea if you want to mess around with the scale factors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeoGBP bug Something in our code isn't working
Projects
None yet
Development

No branches or pull requests

2 participants