Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiarch docker images #46

Open
sontek opened this issue Jan 2, 2023 · 8 comments
Open

Support multiarch docker images #46

sontek opened this issue Jan 2, 2023 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sontek
Copy link
Contributor

sontek commented Jan 2, 2023

Currently we only support amd64:

❯ docker image inspect ghcr.io/zapier/prom-aggregation-gateway:v0.5.0|grep -i arch
        "Architecture": "amd64",

We should publish arm images as well.

@mplachter mplachter added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 20, 2023
@cwboden
Copy link
Contributor

cwboden commented Oct 26, 2023

Not sure if discussion is preferred here or in the PR, but I took a stab at adding multi-arch support in #81.

Hoping for a merge soon, as we've recently migrated to arm64 nodes, but still would like to use the push gateway! 😁

@cwboden
Copy link
Contributor

cwboden commented Nov 7, 2023

This issue can now be closed, since #81 has been merged :)

EDIT: Actually, I think we need to run the github-pages Pipeline before multi-arch is available for consumption, so we can keep this open until then.

@cwboden
Copy link
Contributor

cwboden commented Feb 27, 2024

@mplachter Does something need to be done to run the deployment pipeline? I would like to see a new artifact with the fix, but one hasn't kicked off since #81 was merged

@CallumD
Copy link

CallumD commented Mar 12, 2024

I also need this (thanks @cwboden) so would love to see the build run. Possibly @djeebus can assist?

@djeebus
Copy link
Collaborator

djeebus commented Mar 12, 2024

Apologies! Thanks for the ping, let me get this released.

@yafanasiev
Copy link

@djeebus we are psyched to see this release, but it looks like release pipeline had failed

@djeebus
Copy link
Collaborator

djeebus commented Mar 13, 2024

Yup, I've got the release pipeline fixed (probably), but there's something odd going on with the skaffold build. Still working on it. Stay tuned!

@djeebus
Copy link
Collaborator

djeebus commented Mar 13, 2024

Well that was fun and strange. We're good now though! v0.9.0 should be a multiarch image, tested on x86 and an apple m2. Have fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants