Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When user doesn't have an active Discord account, use a Github avatar as a fallback #42

Open
Techcable opened this issue Jul 4, 2020 · 3 comments
Labels
priority: low Issue has low priority for resolution type: feature New feature or request
Milestone

Comments

@Techcable
Copy link

I'm a big fan of user avatars and I get quite attached to them. This would make it somewhat nicer to talk with members of our community who choose to continue using IRC.
Most IRC users have the 'HideMail' flag enabled, so I'm thinking we try to lookup a github user that matches the IRC account. We could possibly restrict this to registered IRC users to avoid spamming the Github API.

Dicussed (on discord)[https://discordapp.com/channels/289587909051416579/555469074080202765/729044968773124147]

I'm just putting this here so I don't forget about this 😄

It was also mentioned that the existing functionality could (theoretically) be abused. For example, RoboMWM doesn't have an IRC account. It would be possible to create a discord user with his name with some avatar he doesn't like. Not really sure what a good solution to this would be since IRC usernames could probably be spoofed even more easily.

@zachbr
Copy link
Owner

zachbr commented Jul 4, 2020

Spoofing is not a concern. It is up to the guilds and IRC channels to handle that. Not a concern for this project.

@Techcable
Copy link
Author

That's good :)

Phoenix suggested also using the Paper forums as another fallback. As an alternative to gravitar he suggested libavatar (though that seems to require an email address as well).

Also, Aikar had a very fun fallback using RoboHash

By using ?set=4 it can automatically generate kittens (instead of robots). Here's an example for my username:
Kitten
Much more fun than the default!

@Chew
Copy link

Chew commented Jul 21, 2020

Could also support IRCCloud avatars. Every IRCCloud user has their username set as [s/u]id[id], and their avatar (if they have one) is https://static.irccloud-cdn.com/avatar-redirect/[id]. I was going to try and PR this myself however user details aren't passed to the webhook maker.

@zachbr zachbr added type: feature New feature or request priority: low Issue has low priority for resolution labels Oct 3, 2020
@zachbr zachbr added this to the 1.4.0 milestone Apr 2, 2021
@zachbr zachbr modified the milestones: 1.4.0, 2.0.0 Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Issue has low priority for resolution type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants