-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some examples might require additional dependencies #5026
Comments
Hi, and welcome to yt! Thanks for opening your first issue. We have an issue template that helps us to gather relevant information to help diagnosing and fixing the issue. |
yes, I can see a couple ways we could maybe improve this experience:
|
The error message is clear enough, the problem is that it is unexpected. What I would do is this:
|
It seems I already worked on this problem in the past. Here's what I found
Though I agree there's still room for improvement ! I like your solution of an adding a new set of extras. In fact, your suggestion resonates a lot with an on-going discussion that's happening over at astropy (see for instance conda-forge/astropy-feedstock#137). This even lead to a (draft) PEP: astrofrog/peps#1 (currently open for feedback !). I think I would prefer naming the new extra "recommended" to mirror astropy's similar set of "optional but strongly recommended" dependencies. This would also provide a nice solution to #4690, where we couldn't agree on whether h5py should be a required dependency or not. Updating the docs is an obvious yes, though we should first see if the rest of your proposal makes sense to other devs. |
Bug report
Bug summary
I noticed this while trying the external package yt-idv, but I thin it might be a bug here, as it seems related to
the loading of sample datasets from yt itself.
It might also be a shortcoming in the documentation in this or the other project.
Feel free to move the issue there if this is not the case.
Code for reproduction
Actual outcome
and then in series the same for
pandas
andh5py
respectively.Expected outcome
The example should work immediately (and it does, when those 3 dependencies are installed).
Version Information
The text was updated successfully, but these errors were encountered: