Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming in libyt Fields #30

Open
cindytsai opened this issue Oct 13, 2021 · 0 comments
Open

Naming in libyt Fields #30

cindytsai opened this issue Oct 13, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request pri-low Priority: low

Comments

@cindytsai
Copy link
Collaborator

cindytsai commented Oct 13, 2021

Naming in libyt Fields

Frontend Native Fields: Fields defined in XXXFieldInfo in yt frontends. They can be fields derived from other existing fields with function defined inside XXXFieldInfo.

Things Should be Aware of

Field defined in XXXFieldInfo might not have the same name used inside libyt. For example, MagX and CCMagX in gamer. The first one is used inside inline-analysis, while the second one used in post-processing, even though both of them represent the same field.
Function defined inside XXXFieldInfo which derived these added fields don't know they are the same, and it should get MagX instead of CCMagX in inline-analysis. So it ends up an error.

Enhancement

Should add another data member in yt_field to match to an already exist definition inside XXXFieldInfo.

@cindytsai cindytsai added bug Something isn't working enhancement New feature or request pri-medium Priority: medium labels Oct 13, 2021
@cindytsai cindytsai self-assigned this Oct 13, 2021
@cindytsai cindytsai added pri-low Priority: low and removed bug Something isn't working pri-medium Priority: medium labels Oct 14, 2021
@cindytsai cindytsai changed the title Support All Frontend Native Fields Naming in libyt Fields Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pri-low Priority: low
Projects
None yet
Development

No branches or pull requests

1 participant