Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not have the /s/ in the url #5

Open
liamlah opened this issue Jul 22, 2023 · 16 comments
Open

Option to not have the /s/ in the url #5

liamlah opened this issue Jul 22, 2023 · 16 comments
Labels
enhancement New feature or request

Comments

@liamlah
Copy link

liamlah commented Jul 22, 2023

Is your feature request related to a problem?

This is a great idea, thank you for creating this.

If I am dedicating a domain/subdomain to this service, ideally I'd want the url to be as short as functionally possible. The /s/ seems like 2 potentially unnecessary characters.

Describe the solution you'd like

If technically feasible an option to not have the /s/ in the url.

Additional context

I do independent technical support, and this could help me when directing someone to a url over the phone, in a situation where a url is being communicated verbally, the fewer characters, the better

@liamlah liamlah added the enhancement New feature or request label Jul 22, 2023
@fidst
Copy link

fidst commented Jul 22, 2023

This would be cool, even if it was an option panel to choose what you'd like in place of the /s/.

  • /s/
  • /
  • /[custom]/

@danmed
Copy link

danmed commented Jul 22, 2023

This is the only thing stopping me from switching from yourls to this.. i don't need a /s/ i just want domain/custom

@PaddyPat
Copy link

If you use a reverse proxy like caddy

s.domain.com {
@subdir {
 not path /s/*
 not file
 }
 rewrite @subdir /s{uri}
 reverse_proxy 172.17.0.1:8880
}

This will redirect s.domain.com/link to s.domain.com/s/link and redirects to destination

@mobiledude
Copy link

If you use a reverse proxy like caddy

s.domain.com {
@subdir {
 not path /s/*
 not file
 }
 rewrite @subdir /s{uri}
 reverse_proxy 172.17.0.1:8880
}

This will redirect s.domain.com/link to s.domain.com/s/link and redirects to destination

would the same work nginx proxymanager?

@PaddyPat
Copy link

If you use a reverse proxy like caddy

s.domain.com {
@subdir {
 not path /s/*
 not file
 }
 rewrite @subdir /s{uri}
 reverse_proxy 172.17.0.1:8880
}

This will redirect s.domain.com/link to s.domain.com/s/link and redirects to destination

would the same work nginx proxymanager?

Think so but I don’t use nginx.. it’s too complicated

@RealFascinated
Copy link
Contributor

Is there any plans to implement this?

@boojack
Copy link
Collaborator

boojack commented Jan 21, 2024

It's probably impossible to remove the s/ prefix from slash itself. However, it is recommended that you use a reverse proxy such as nginx to do so.

@rdamazio
Copy link

Would you be open to a pull request making this happen? It seems pretty easy to do.

@rdamazio
Copy link

(And btw, in Chrome my workaround so far is to add a search engine defined as the Slash url, and basically use space instead of / - but not ideal if you're deploying to many users)

@boojack
Copy link
Collaborator

boojack commented Mar 25, 2024

@rdamazio FYI, Slash have another model Collection for sharing selected shortcuts, like a folder. And it would be prefixed with c/. So I think the necessary prefixes are needed.

image

@rdamazio
Copy link

rdamazio commented Mar 25, 2024

@rdamazio FYI, Slash have another model Collection for sharing selected shortcuts, like a folder. And it would be prefixed with c/. So I think the necessary prefixes are needed.

You can just make one or both prefixes configurable - e.g. still use /c for collections but configure no prefix for shortcuts. Obviously that prevents having a shortcut called "c" (as well as one named the same as the prefix for the admin pages and API endpoints), but that's minor.

@adiologydev
Copy link

adiologydev commented Apr 8, 2024

Surprised this isn't a thing yet.

@craftzneko
Copy link

It would be good to have configurable prefix's or none at all. We are looking for a shorting service to run internally and this would fit the bill without the prefix

@rdamazio
Copy link

I took a first stab at this and got the server side working and part of the frontend, but my limited knowledge of React is making it very slow to make the frontend changes (I'm a backend person). Would anyone like to take over what I have so far?

@adiologydev
Copy link

I took a first stab at this and got the server side working and part of the frontend, but my limited knowledge of React is making it very slow to make the frontend changes (I'm a backend person). Would anyone like to take over what I have so far?

Sure, I'd be happy to finish this up.

@rdamazio
Copy link

I took a first stab at this and got the server side working and part of the frontend, but my limited knowledge of React is making it very slow to make the frontend changes (I'm a backend person). Would anyone like to take over what I have so far?

Sure, I'd be happy to finish this up.

Pushed to https://github.com/rdamazio/slash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants