Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON serialization of ImageConfiguration is non-deterministic #249

Open
allisonkarlitskaya opened this issue Oct 25, 2024 · 1 comment
Open

Comments

@allisonkarlitskaya
Copy link

Sometimes you get

        "Labels": {
            "maintainer": "[email protected]",
            "containers.composefs.fsverity": "6c8fb1443b014c416e3ebddd8c75307182661f9093f83d3700499e7601aecb61"
        }

sometimes you get

        "Labels": {
            "containers.composefs.fsverity": "6c8fb1443b014c416e3ebddd8c75307182661f9093f83d3700499e7601aecb61",
            "maintainer": "[email protected]"
        }

ie: probably we ought to sort by key before writing the JSON. Or maybe use an inherently-sorted type. Or at least ordered.

@cgwalters
Copy link
Contributor

cgwalters commented Oct 25, 2024

In ocidir we use https://docs.rs/olpc-cjson/latest/olpc_cjson/ by default (ref code) but... containers/ocidir-rs#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants