Skip to content

The value field in the ThresholdsStep should be a Number? #12

Open
iguissouma opened this issue Jun 23, 2021 · 0 comments
Open

The value field in the ThresholdsStep should be a Number? #12

iguissouma opened this issue Jun 23, 2021 · 0 comments

Comments

@iguissouma
Copy link

iguissouma commented Jun 23, 2021

Hello, thanks for this great DSL!

I'm not a graphana expert, I started playing with the DSL, I think the value field in the ThresholdsStep should be a Number?

class ThresholdsStep(private val value: String = "null", private val color: Color = Color.GREEN) : Json<JSONObject> {

    override fun toJson(): JSONObject = jsonObject {
        "value" to value
        "color" to color.asHexString()
    }
}

thanks in advance.

@iguissouma iguissouma changed the title The value field in the ThresholdsStep should be an Int? The value field in the ThresholdsStep should be a Number? Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant