Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'accept' option is not attached to the file input tag #107

Open
diegonc opened this issue Apr 22, 2016 · 1 comment
Open

'accept' option is not attached to the file input tag #107

diegonc opened this issue Apr 22, 2016 · 1 comment

Comments

@diegonc
Copy link

diegonc commented Apr 22, 2016

Since 54ebd4b (Utilize mpowaga:jquery-fileupload package), the accept attribute is not present in the input file. The template for the upload button is receiving
the following data:

+  selectFileBtnData: ->
+    label: @atts.label or 'Choose file'
+    accepts: @atts.accepts

but the template is still referencing accept helper.

Did accepts (plural) meant to support the same functionality as the old accept helper[1]?

If yes, please rename it back to the singular form so you don't have to change documentation or existing apps.

If not then there's a problem :)


[1] For your reference, the commit history affecting this feature:

  • f70ca79 added configurable accept attribute (working?)
  • 924cf7b Refactorization (broken?)
  • 2ad90c5 Support accept attribute (working?)
  • 54ebd4b Utilize mpowaga:jquery-fileupload package (broken?)
@jc2
Copy link

jc2 commented Sep 22, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants