Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type conversions #1

Open
yin opened this issue Jan 11, 2017 · 1 comment
Open

Remove type conversions #1

yin opened this issue Jan 11, 2017 · 1 comment

Comments

@yin
Copy link
Owner

yin commented Jan 11, 2017

User can do type-conversion directly after fetching flag value. This feature added bulk of hard-to-test code, which is likely not to be reused nor maintained in future.

    String userID = arg_user.get();
    User user = UserResolver.find(userID);

Custom flag type were avoided by gflags. All parsing should be done after fetching the string value in the client code.

@yin
Copy link
Owner Author

yin commented Aug 8, 2017

Done in v0.3.0-beta1, but the alternative way of defining new flag-types must be documented before closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant