You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of 5.1.0, notifications are displayed at most once per interval period, because the fetched update is deleted once "emitted" (ie set to this.update)
this.update=this.config.get('update');if(this.update){// Use the real latest version instead of the cached onethis.update.current=this.packageVersion;// Clear cached informationthis.config.delete('update');}
This is a bit weird to me, wouldn't it be better if the update message was displayed consistently as long as there is an update? Some users might miss that there is an available update quite easily.
Some workarounds I'm using to ensure that once an update gets fetched, it remains visible, and trying to fetch it before the first interval:
// Hacky way to ensure we check for updates on first run// Note: the notification will only happen in the 2nd run anywayif(!notifier.disabled&&Date.now()-notifier.config.get('lastUpdateCheck')<50){notifier.config.set('lastUpdateCheck',0);notifier.check();}if(notifier.update&¬ifier.update.current!==notifier.update.latest){// Because notifier clears cached data after reading it, leading to notifier not consistently displaying the updatenotifier.config.set('update',notifier.update);// Display notification}
Having a more convenient way to achieve all this could be useful
The text was updated successfully, but these errors were encountered:
Considering there's a way to disable the update-notifier already, they can just temporarily disable it.
I can also expose my own way to allow disabling this through our own config, so that it's clearly documented for my users. The notification may even link to that config option doc so that user can disable it very easily
As of 5.1.0, notifications are displayed at most once per interval period, because the fetched update is deleted once "emitted" (ie set to
this.update
)This is a bit weird to me, wouldn't it be better if the update message was displayed consistently as long as there is an update? Some users might miss that there is an available update quite easily.
Some workarounds I'm using to ensure that once an update gets fetched, it remains visible, and trying to fetch it before the first interval:
Having a more convenient way to achieve all this could be useful
The text was updated successfully, but these errors were encountered: