Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Road Map] New Release #759

Open
8 of 15 tasks
UlisesGascon opened this issue Jun 3, 2019 · 8 comments
Open
8 of 15 tasks

[Road Map] New Release #759

UlisesGascon opened this issue Jun 3, 2019 · 8 comments

Comments

@UlisesGascon
Copy link
Member

UlisesGascon commented Jun 3, 2019

Hi all!

I opened this issue to keep tracking and an open discussion about the next release features and priorities.

New features & refactors

Bugs to be fixed

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Jun 3, 2019

I will open a PR for the testing part soon, also for dependencies ;-)

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Jun 4, 2019

@silvenon .. what do you think about this testing workflow? Open to discussion for all of you as well! 😉
test_demo

I will improve the Unit testing with a real testing example (Mocha, Jest, Ava & Jasmine), as well I will cover the example with Cypress for e2e.

Note: You can ignore the creation files log, as this is only a test for the workflow and not a real implementation yet

@silvenon
Copy link
Member

silvenon commented Jun 5, 2019

Btw, I updated the name of the milestone to v4.0.0 because so far we have pre-releases, which means that the next stable release will be v4.0.0.

@silvenon
Copy link
Member

silvenon commented Jun 5, 2019

what do you think about this testing workflow?

I like it!

@UlisesGascon
Copy link
Member Author

Awesome! v4.0 then :-)

I will prepare the PR asap 🎉

UlisesGascon added a commit to UlisesGascon/generator-webapp that referenced this issue Jun 5, 2019
UlisesGascon added a commit to UlisesGascon/generator-webapp that referenced this issue Jun 5, 2019
- Babel config now supports modules (imp/exp)
-  Added module support in the index.html
-  Added sample function in main.js for future unit testing
- Tests updated
UlisesGascon added a commit to UlisesGascon/generator-webapp that referenced this issue Jun 5, 2019
UlisesGascon added a commit to UlisesGascon/generator-webapp that referenced this issue Jun 5, 2019
UlisesGascon added a commit to UlisesGascon/generator-webapp that referenced this issue Jun 5, 2019
UlisesGascon added a commit to UlisesGascon/generator-webapp that referenced this issue Jun 5, 2019
- Babel config now supports modules (imp/exp)
-  Added module support in the index.html
-  Added sample function in main.js for future unit testing
- Tests updated
UlisesGascon added a commit to UlisesGascon/generator-webapp that referenced this issue Jun 5, 2019
- Updated generator tests
- Improved combined tests behaviour (e2e + unit) as single task
- Added Jest sample test based in main.js' greetings function
UlisesGascon added a commit to UlisesGascon/generator-webapp that referenced this issue Jun 5, 2019
- Updated generator tests
- Added Ava sample test based in main.js' greetings function
@silvenon
Copy link
Member

silvenon commented Jun 9, 2019

@UlisesGascon could you explain these two tasks?

  • Refactor Jasmine (remove sub-generator)
  • Refactor Mocha (remove sub-generator)

Are they referring to a discussion we had somewhere?

@silvenon
Copy link
Member

silvenon commented Jun 9, 2019

I'd also remove the AVA task for v4.0.0 and leave it for v4.1.0, if you agree. Because it's a new feature that requires creating a new generator, and since this doesn't appear to be a highly requested feature I suggest not blocking a stable release of generator-webapp because of this.

@UlisesGascon
Copy link
Member Author

@silvenon and interested people... can we move the discussion to PR #763? I think that it will be easier to discuss with some code ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants