Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a .prettierignore file #209

Open
danielo515 opened this issue Oct 28, 2017 · 3 comments
Open

Consider adding a .prettierignore file #209

danielo515 opened this issue Oct 28, 2017 · 3 comments

Comments

@danielo515
Copy link

Hello,

Thanks for this generator. However, it can be a bit frustrating when you start using it. The reason is because JSON template files are being piped through prettier on every commit. Obviously, template files do not pass any JSON linter. According to prettier documentation is as easy as adding a .prettierignore file. The content should be **/templates

I tried it and works like a charm.

Thanks in advance

@mischah
Copy link
Member

mischah commented Oct 28, 2017

Good idea. Would you like to create an PR for that?

@danielo515
Copy link
Author

Sure ! Where should I add the file ? On the main generator or in the subgenerator?

@SBoudrias
Copy link
Member

SBoudrias commented Oct 29, 2017

I'd say main generator probably. Prettier is added by generator-node, and generator-generator is composed on top of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants