Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tokens with callback hooks #219

Open
fubuloubu opened this issue Feb 23, 2021 · 0 comments
Open

Support tokens with callback hooks #219

fubuloubu opened this issue Feb 23, 2021 · 0 comments
Labels
enhancement New feature or request p3 Fix if time

Comments

@fubuloubu
Copy link
Member

From audit:

"Callbacks. Some token standards, e.g. ERC223, ERC721, and ERC777, define callbacks. Some of these callbacks can be invoked upon regular “transfer” calls. This creates a significant security risk in the form of reentrancies. Inside the strategy additional protection measures might be required depending on the token type and its handling. The vault already has reentrancy locks that should be sufficient for most tokens."

NOTE: Currently we do not support other token standards besides ERC20, so it remains to be seen if we would like to support these.

@fubuloubu fubuloubu added the enhancement New feature or request label Feb 23, 2021
@saltyfacu saltyfacu added the p3 Fix if time label Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p3 Fix if time
Projects
None yet
Development

No branches or pull requests

2 participants