Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tabs do not generate with custom layout #766

Open
3 tasks done
JasperZP opened this issue Nov 18, 2024 · 3 comments
Open
3 tasks done

Some tabs do not generate with custom layout #766

JasperZP opened this issue Nov 18, 2024 · 3 comments

Comments

@JasperZP
Copy link

JasperZP commented Nov 18, 2024

Prerequisites

  • I have read FAQ
  • I have searched existing issues (including closed ones)
  • I use KiKit at least version 1.6.0 (older version are not supported)

KiKit version

kikit, version 0+unknown (installed extra/python-kikit 1.6.0-2 on archlinux)

KiCAD version

8.0.6

Operating system

Archlinux, 6.11.7

Description

Some tabs do not generate with custom layout.
I wrote a simple layout plugin that offsets alternating rows by 1.6mm, and rotates the first row by 180deg which looks like this:
image

However, it does not generate all tabs as specified by the KiKit:tab footprint, especially those on the right side of the board:
image

If I use the same layout plugin but remove the horizontal offset, the tabs do generate correctly.
The partition lines and bouding boxes all seem to be correct.

Steps to Reproduce

  1. Download the attached board, config file, and plugin here: files.zip
  2. Run: kikit panelize -p kikit_config.json main_bare.kicad_pcb panel.kicad_pcb
  3. Check output to see that tabs are not generated on one side of the board
@yaqwsx
Copy link
Owner

yaqwsx commented Nov 18, 2024

I just took your code and ran it - the partition line definitely doesn't look correct:

Screenshot from 2024-11-18 17-05-46

This is the reason why the tabs are not generated. I haven't been able to find the problem in the partition line generator so far. As a temporary workaround, I suggest building the partition line in the script manually. It should be straightforward for your layout.

@JasperZP
Copy link
Author

JasperZP commented Nov 19, 2024

Ahh that looks more like the actual partition line. How were you able to show the partition lines like that? When I run panel.debugRenderPartitionLines() at the end of the layout plugin I get this on layer User.Eco1:
image

@JasperZP
Copy link
Author

Ah nevermind, I got it working now (when I ran panel.debugRenderPartitionLines() at the end of the buildPartitionLine function it shows the real parition line). Created the lines manually and now it generates the tabs correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants