Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple outlines #748

Closed
3 tasks done
bobatsar opened this issue Oct 10, 2024 · 2 comments
Closed
3 tasks done

Multiple outlines #748

bobatsar opened this issue Oct 10, 2024 · 2 comments

Comments

@bobatsar
Copy link

Prerequisites

  • I have read FAQ
  • I have searched existing issues (including closed ones)
  • I use KiKit at least version 1.6.0 (older version are not supported)

KiKit version

kikit, version 1.6.0

KiCAD version

8.0.5

Operating system

Ubuntu 24.04

Description

I have a project with a complicated outline.
When trying to panelize it, I get the error

An error occurred: test.kicad_pcb: Multiple outlines (4) at [144.694624, 95.943444]
No output files produced

I can't find the error in my files as at the specified coordinate is no outline at all.

  • When the inner outline is removed, kikit runs without error but the result does not reflect the original outline at all.
  • When removing the outer outline kikit runs without error but also the result does not reflect the original.

Steps to Reproduce

Run

❯ kikit panelize \
    --layout 'grid; rows: 2; cols: 2;' \
    --tabs full \
    --cuts vcuts \
    test.kicad_pcb panel.kicad_pcb
An error occurred: test.kicad_pcb: Multiple outlines (4) at [144.694624, 95.943444]

with the example files.

kikit_multiple_outlines.zip

@yaqwsx
Copy link
Owner

yaqwsx commented Oct 11, 2024

This was fixed in 46b2ea9.

The problem is that KiCAD's polygons don't use properties GetStart() and GetEnd() for their start/end points. They always return a fixed coordinate. However, we have never noticed as all our test cases used a single polygon (possibly with holes)

@yaqwsx yaqwsx closed this as completed Oct 11, 2024
@bobatsar
Copy link
Author

Thanks for the fix.

The error is now gone but the outline in the panel does not match the original at all. I just opened #749.

tested with kikit, version 1.6.0+7.g309b937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants