Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModbusRTU instance emits error events #515

Open
everhardt opened this issue Sep 26, 2023 · 0 comments
Open

ModbusRTU instance emits error events #515

everhardt opened this issue Sep 26, 2023 · 0 comments

Comments

@everhardt
Copy link
Contributor

everhardt commented Sep 26, 2023

The ModbusRTU instance can emit error events since #380. If that error event is not listened for, by default the whole processes crashes. The on('error', ..) handler is not available in the Typescript types.

I'll file a PR in a minute to add it to the Typescript types. I wonder though why we need this. The single client port that emits error events is the RTUBufferedPort. Shouldn't it do handleCallback like the other ports?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant