Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22626: Long file names collide with elements from the right side on Office Importer on Firefox #3761

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Dec 12, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22626

Changes

Description

  • Fixed the overflow by adding a max-width.

Clarifications

  • This is a safe change that will only act when there's an overflow. The regular use case shouldn't be influenced by this change.
  • Note that it's not possible to wrap this content cleanly with CSS, because it's all inside a input type='file'. There's a pseudo element to customize the button, but no way to access advanced CSS for the filename. All solutions I could find online were using JS to change the content of the displayed filename directly.

Screenshots & Video

The ticket was reported for Firefox with a zoom level above 100%, the screenshots below are taken in those conditions.
Before the changes in this PR:
Screenshot from 2024-12-12 15-06-59
After the changes in this PR:
Screenshot from 2024-12-12 15-06-13

We can see that the input does not longer overflows on the rest of the form. The overflowing filename is now partly hidden.

Executed Tests

Manual tests, see screenshots above.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 16.10.X (pretty safe style change)

…e on Office Importer on Firefox

* Fixed the overflow by adding a max-width. This is a safe change that will only act when there's an overflow. The regular use case shouldn't be influenced by this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant