Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage of exceptions #16

Open
egpbos opened this issue Oct 26, 2017 · 0 comments
Open

Coverage of exceptions #16

egpbos opened this issue Oct 26, 2017 · 0 comments

Comments

@egpbos
Copy link
Member

egpbos commented Oct 26, 2017

In basic.hpp, there are a few exceptions to safeguard against nullptrs from FFTW plan creation, which for instance can happen if you try to build a plan for a multi-dimensional real FFT with a FFTW_PRESERVE_INPUT flag, because such algorithms are not available in FFTW. These exceptions are there more as a developer safeguard than a user safeguard. Eventually, it would be nicer if such "illegal" combinations of plan parameters were disallowed by the code itself, e.g. by not allowing users to manually specify planner flags, but to hard code all legal possibilities. This will eliminate the need for the exceptions.

Therefore, note to self: don't try to get 100% coverage by making a test with illegal input, or something like that. Just fix the API so that the exceptions can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant