Skip to content

Commit 281a61f

Browse files
authored
Remove title from inline SVGs (jakearchibald#359)
The parent element already has the title set. Also, add `aria-hidden="true"` in the SVGs.
1 parent 30b1973 commit 281a61f

File tree

5 files changed

+5
-8
lines changed

5 files changed

+5
-8
lines changed

src/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ <h1>SVGOMG</h1>
8686
</div>
8787
<div class="toolbar">
8888
<div class="menu-toolbar-item">
89-
<button class="unbutton menu-btn" type="button">
89+
<button class="unbutton menu-btn" type="button" title="Menu">
9090
{% include "partials/icons/menu.svg" %}
9191
</button>
9292
</div>

src/js/page/ui/bg-fill-button.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ export default class BgFillButton extends FloatingActionButton {
88
title,
99
iconSvg:
1010
// prettier-ignore
11-
'<svg class="icon" viewBox="0 0 24 24">' +
12-
`<title>${title}</title>` +
11+
'<svg aria-hidden="true" class="icon" viewBox="0 0 24 24">' +
1312
'<path d="M21.143 9.667c-.733-1.392-1.914-3.05-3.617-4.753C14.549 1.936 12.048 1 10.741 1c-.414 0-.708.094-.86.246L8.52 2.606c-1.899-.236-3.42.106-4.294.983-.876.875-1.164 2.159-.792 3.523.492 1.806 2.305 4.049 5.905 5.375.038.323.157.638.405.885.588.588 1.535.586 2.121 0s.588-1.533.002-2.119a1.5 1.5 0 0 0-2.123-.001l-.17.256c-2.031-.765-3.395-1.828-4.232-2.9l3.879-3.875c.496 2.73 6.432 8.676 9.178 9.178l-7.115 7.107c-.234.153-2.798-.316-6.156-3.675-3.393-3.393-3.175-5.271-3.027-5.498L3.96 9.989C3.521 9.63 3.035 8.886 2.819 8.3L.685 10.431C.24 10.877 0 11.495 0 12.251c0 1.634 1.121 3.915 3.713 6.506C6.477 21.521 9.293 23 11.145 23c.648 0 1.18-.195 1.547-.562l8.086-8.078c.91.874-.778 3.538-.778 4.648a2 2 0 0 0 4-.001c0-3.184-1.425-6.81-2.857-9.34zM4.934 4.296c.527-.53 1.471-.791 2.656-.761L4.381 6.741c-.236-.978-.049-1.845.553-2.445zm9.292 4.079-.03-.029C12.904 7.054 10.393 3.99 11.1 3.283c.715-.715 3.488 1.521 5.062 3.096.862.862 2.088 2.247 2.937 3.458-1.717-1.074-3.491-1.469-4.873-1.462z"/>' +
1413
'</svg>',
1514
});

src/js/page/ui/copy-button.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ export default class CopyButton extends FloatingActionButton {
88
title,
99
iconSvg:
1010
// prettier-ignore
11-
'<svg class="icon" viewBox="0 0 24 24">' +
12-
`<title>${title}</title>` +
11+
'<svg aria-hidden="true" class="icon" viewBox="0 0 24 24">' +
1312
'<path d="M16 1H4C3 1 2 2 2 3v14h2V3h12V1zm3 4H8C7 5 6 6 6 7v14c0 1 1 2 2 2h11c1 0 2-1 2-2V7c0-1-1-2-2-2zm0 16H8V7h11v14z"/>' +
1413
'</svg>',
1514
});

src/js/page/ui/download-button.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ export default class DownloadButton extends FloatingActionButton {
1010
href: './',
1111
iconSvg:
1212
// prettier-ignore
13-
'<svg class="icon" viewBox="0 0 24 24">' +
14-
`<title>${title}</title>` +
13+
'<svg aria-hidden="true" class="icon" viewBox="0 0 24 24">' +
1514
'<path d="M19 9h-4V3H9v6H5l7 7 7-7zM5 18v2h14v-2H5z"/>' +
1615
'</svg>',
1716
major: true,

src/partials/icons/menu.svg

Lines changed: 1 addition & 1 deletion
Loading

0 commit comments

Comments
 (0)