New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dll-interface warnings on Windows builds #89

Open

mr-smidge opened this issue May 9, 2023 · 0 comments

Labels

build

Contributor

mr-smidge commented May 9, 2023

Windows builds issue the following warning, due to the use of the pimpl idiom using std::shared_ptr<>, e.g:

warning C4251: 'djinterop::database::pimpl_
': class 'std::shared_ptr<djinterop::database_impl>' needs to have dll-interface to be used by clients of class 'djinte
rop::database' [C:\Users\smidge\Source\libdjinterop\cmake_build\DjInterop.vcxproj]

This can apparently be fixed by specifying DJINTEROP_PUBLIC on individual public methods (ugh), rather than the whole class.

The text was updated successfully, but these errors were encountered:

mr-smidge added the build label

mr-smidge changed the title ~~Remove dll-interface warnings on Windows builds~~ Fix dll-interface warnings on Windows builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment