Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should allow to send message without payload.text #24

Open
shamasis opened this issue Sep 1, 2015 · 5 comments
Open

Should allow to send message without payload.text #24

shamasis opened this issue Sep 1, 2015 · 5 comments

Comments

@shamasis
Copy link

shamasis commented Sep 1, 2015

This is a valid usage to send with only attachments and no text.

Line 13 of slack.js should be

if (!message.text && !Array.isArray(message.attachments)) {
@shamasis
Copy link
Author

shamasis commented Sep 1, 2015

Currently you can bypass that check by providing text as

{
      toString: function () { return '' }
}

@doggan
Copy link

doggan commented Jan 6, 2016

👍

Thanks for the above workaround.

@sibelius
Copy link

sibelius commented Oct 7, 2016

@shamasis would u mind send a PR to fix this?

@shamasis
Copy link
Author

shamasis commented Oct 8, 2016

Will be glad to. Thanks for asking.

@shamasis
Copy link
Author

shamasis commented Oct 8, 2016

#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants