Decontaminate project

[becca-boo-boo]

While reviewing EARS for a different issue, Boris and myself noticed a couple of hard coded URLs. There are also some other values we should make more generic.

URLs

• SAT_URL

  • ears/internal/pkg/appsecret/config_vault.go

    Line 77 in 4082f51

    const SAT_URL = "https://sat-prod.codebig2.net/oauth/token"

  • ears/internal/pkg/appsecret/config_vault.go

    Line 121 in 4082f51

    //curl -s -X POST -H "X-Client-Id: ***" -H "X-Client-Secret: ***" -H "Cache-Control: no-cache" https://sat-prod.codebig2.net/oauth/token

  • ears/pkg/filter/ws/webservice.go

    Line 47 in 4082f51

    SAT_URL = "https://sat-prod.codebig2.net/oauth/token"

  • ears/pkg/filter/ws/webservice.go

    Line 197 in 4082f51

    //curl -s -X POST -H "X-Client-Id: ***" -H "X-Client-Secret: ***" -H "Cache-Control: no-cache" https://sat-prod.codebig2.net/oauth/token

• CREDENTIAL_URL

  • ears/internal/pkg/appsecret/config_vault.go

    Line 78 in 4082f51

    const CREDENTIAL_URL = "https://{{env}}gears.comcast.com/v2/applications/{{app}}/credentials/{{key}}"

• host

  • ears/internal/pkg/app/docs/doc.go

    Line 22 in 4082f51

    // Host: qa.gears.comcast.com

  • ears/internal/pkg/app/swagger.yaml

    Line 315 in 4082f51

    host: qa.gears.comcast.com

  • ears/internal/pkg/app/ears/openapi/openapi.yaml

    Line 315 in 4082f51

    host: qa.gears.comcast.com

Org

• comcast

Apps

• xfi

Gears

• too many to list

In addition to these changes, we would like to either deprecate/remove or fix the very specific "SAT" implementation in webservice.go.

I am positive this cannot be in use because it absolutely will not work for the use it is clearly intended for and really isn't appropriate for an open source project with its current implementation.

I think we have a few options here.

• One is obviously to just remove this. It cannot possibly be in use in or out of Comcast, it will not work for its intended use in its current form.
• Another option would be to extract this and other oauth2 implementations (Comcast SAT uses oauth2) into one generic and flexible method. Ideally this would also have a more robust and generic http handler or use one.

I think there are also some issues here where I can clearly see some structural echoes of our internal platform. It seems like we did not properly separate the specific internal implementation we would need from this external open source project.

All these issues should be resolved and then we should remediate the git history. I will be working with OSAC to get help here.