Add sequential example #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glema-xmartlabs
requested changes
May 6, 2024
examples/sequential/preprocessing.py
Outdated
| from tf_tabular.utils import get_vocab | ||
|
|
||
|
|
||
| def divide_ratings_by_mean_user_rating(ratings: pd.DataFrame, user_id_column='user_id'): |
There was a problem hiding this comment.
why divide?
please add a simple doc string "Substract mean rating for each user"
examples/sequential/preprocessing.py
Outdated
| ratings = ratings[["user_id", "movie_id", "user_rating"]].groupby(["user_id"], as_index=False).agg(list) | ||
|
|
||
| def cutoff(x): | ||
| return min(int(len(x) * 0.2), max_y_cutoff) |
examples/sequential/preprocessing.py
Outdated
|
|
||
|
|
||
| def preprocess_dataset(ratings_df, movies_df): | ||
| train_df, val_df = split_by_user(ratings_df, max_y_cutoff=5) |
src/tf_tabular/utils.py
Outdated
| @@ -142,7 +145,7 @@ def build_categorical_input(name, embedding_dim, vocab, is_multi_hot, embedding_ | |||
| return (x, inp) | |||
|
|
|||
|
|
|||
| def get_vocab(series, max_size): | |||
| def get_vocab(series, max_size: int = None): | |||
examples/sequential/preprocessing.py
Outdated
Comment on lines
59
to
60
| val_users = unique_users[: int(num_users * 0.2)] | ||
| train_users = unique_users[int(num_users * 0.2) :] |
glema-xmartlabs
requested changes
May 7, 2024
pgrill
reviewed
May 8, 2024
examples/sequential/preprocessing.py
Outdated
| train_set = ratings[ratings.user_id.isin(train_users)] | ||
| val_set = ratings[ratings.user_id.isin(val_users)] | ||
|
|
||
| print(f"Train set size: {train_set.shape}") |
There was a problem hiding this comment.
I don't like much the idea of having prints in the code. Can we change them for logging.info?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some fixes needed for this use case and removed unused conftest file