Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in iPhone X above models , menu goes to safeArea #759

Open
narjes-abs opened this issue Oct 8, 2019 · 7 comments
Open

in iPhone X above models , menu goes to safeArea #759

narjes-abs opened this issue Oct 8, 2019 · 7 comments

Comments

@narjes-abs
Copy link

Screen Shot 2019-10-08 at 11 43 24 AM

@mehul-vasa
Copy link

Same problem. Any solutions?

@bivant
Copy link

bivant commented Nov 7, 2019

For me it is not clear enough what is wrong on the screenshot. Check the pull requests section, there are some with safe area issues (e.x. #756)

@narjes-abs
Copy link
Author

@bivant your right I should be more specific, here is the screenshot of iPhone 6
XLPagerTabStrip should be shown like this
photo_2019-11-10_09-26-14

@bivant
Copy link

bivant commented Nov 10, 2019

Hello @abbaspour-narjes
Now it more clear. Title "Trailer" is under the notch. Can you attach minimal project where issue is visible? To check the layout/constraints. I assume it depends on layout as not many people encountered it.

@clementiano9
Copy link

I think this issue still exists and it's affecting ios13 where view controllers are shown modally in a page sheet, the title is not visible even though the top of the page sheet is below the notch, when I change the view controller's presentation to full screen the title appears again.
The question is, how do we support the new ios page sheet style? @bivant

@FaizalMalik
Copy link

FaizalMalik commented Dec 23, 2019

Yes , I am also facing the same issue..! In Demo the view controller is presented so there is no issues.
Screen Shot 1441-04-26 at 5 29 32 PM

But When I present modally It works fine..!

Screen Shot 1441-04-26 at 6 05 11 PM

@mohamedghonemi
Copy link

One workaround I found is to use separate view for the buttonBarView (Empty ButtonBarView) and attach it to the outlet in the controller. then you can place it right in the view .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants