Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with plugin which filter active_plugins #1182

Open
willmot opened this issue Jul 13, 2017 · 0 comments
Open

Conflict with plugin which filter active_plugins #1182

willmot opened this issue Jul 13, 2017 · 0 comments
Labels

Comments

@willmot
Copy link
Contributor

willmot commented Jul 13, 2017

We have a conflict with the Plugin Organiser plugin because of the way we reorganize the active_plugins array in https://github.com/humanmade/backupwordpress/blob/master/classes/class-plugin.php#L325:L346

Plugin Organizer allows users to hide plugins from the Plugins list table, it does this by filtering the array of active_plugins and removing plugins that are hidden.

Because we pull the list of active plugins and then save back to the database we’re having the side effect of saving back the modified list after Plugin Organizer has removed the hidden ones, this then causes them to become deactivated.

See https://wordpress.org/support/topic/it-disables-plugin-and-leave-it-that-way/ for more detail.

Question, do we actually need to save back to the database, can’t we just rely on rejigging the order at run-time?

@katmoody katmoody added the Bug label Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants