Skip to content

Commit b56c8db

Browse files
ppiaoldv-alt
authored andcommittedOct 26, 2017
netlink: decode netlink message delete flags
* netlink.c: Include "xlat/netlink_delete_flags.h". (decode_nlmsg_flags_crypto, decode_nlmsg_flags_route, decode_nlmsg_flags_xfrm): Decode delete flags. * netlink.h (NLM_F_NONREC): New macro. * xlat/netlink_delete_flags.in: New file. * tests/netlink_crypto.c (test_nlmsg_flags): Check this. * tests/netlink_route.c (test_nlmsg_flags): Likewise. * tests/netlink_xfrm.c (test_nlmsg_flags): Likewise.
1 parent 695de1d commit b56c8db

File tree

6 files changed

+35
-6
lines changed

6 files changed

+35
-6
lines changed
 

‎netlink.c

+10
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
#include <linux/rtnetlink.h>
3535
#include <linux/xfrm.h>
3636
#include "xlat/netlink_ack_flags.h"
37+
#include "xlat/netlink_delete_flags.h"
3738
#include "xlat/netlink_flags.h"
3839
#include "xlat/netlink_get_flags.h"
3940
#include "xlat/netlink_new_flags.h"
@@ -242,6 +243,9 @@ decode_nlmsg_flags_crypto(const uint16_t type)
242243
switch (type) {
243244
case CRYPTO_MSG_NEWALG:
244245
return netlink_new_flags;
246+
case CRYPTO_MSG_DELALG:
247+
case CRYPTO_MSG_DELRNG:
248+
return netlink_delete_flags;
245249
case CRYPTO_MSG_GETALG:
246250
return netlink_get_flags;
247251
}
@@ -252,11 +256,14 @@ decode_nlmsg_flags_crypto(const uint16_t type)
252256
static const struct xlat *
253257
decode_nlmsg_flags_route(const uint16_t type)
254258
{
259+
/* RTM_DELACTION uses NLM_F_ROOT flags */
255260
if (type == RTM_DELACTION)
256261
return netlink_get_flags;
257262
switch (type & 3) {
258263
case 0:
259264
return netlink_new_flags;
265+
case 1:
266+
return netlink_delete_flags;
260267
case 2:
261268
return netlink_get_flags;
262269
}
@@ -280,6 +287,9 @@ decode_nlmsg_flags_xfrm(const uint16_t type)
280287
case XFRM_MSG_NEWSADINFO:
281288
case XFRM_MSG_NEWSPDINFO:
282289
return netlink_new_flags;
290+
case XFRM_MSG_DELSA:
291+
case XFRM_MSG_DELPOLICY:
292+
return netlink_delete_flags;
283293
case XFRM_MSG_GETSA:
284294
case XFRM_MSG_GETPOLICY:
285295
case XFRM_MSG_GETAE:

‎netlink.h

+3
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@
3636
# define NETLINK_SOCK_DIAG 4
3737
#endif
3838

39+
#ifndef NLM_F_NONREC
40+
# define NLM_F_NONREC 0x100
41+
#endif
3942
#ifndef NLM_F_CAPPED
4043
# define NLM_F_CAPPED 0x100
4144
#endif

‎tests/netlink_crypto.c

+9-1
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,17 @@ test_nlmsg_flags(const int fd)
7878
fd, nlh.nlmsg_len, (unsigned) sizeof(nlh), sprintrc(rc));
7979

8080
nlh.nlmsg_type = CRYPTO_MSG_DELALG;
81-
nlh.nlmsg_flags = NLM_F_REPLACE;
81+
nlh.nlmsg_flags = NLM_F_ECHO | NLM_F_NONREC;
8282
rc = sendto(fd, &nlh, sizeof(nlh), MSG_DONTWAIT, NULL, 0);
8383
printf("sendto(%d, {len=%u, type=CRYPTO_MSG_DELALG"
84+
", flags=NLM_F_ECHO|NLM_F_NONREC, seq=0, pid=0}"
85+
", %u, MSG_DONTWAIT, NULL, 0) = %s\n",
86+
fd, nlh.nlmsg_len, (unsigned) sizeof(nlh), sprintrc(rc));
87+
88+
nlh.nlmsg_type = CRYPTO_MSG_UPDATEALG;
89+
nlh.nlmsg_flags = NLM_F_REPLACE;
90+
rc = sendto(fd, &nlh, sizeof(nlh), MSG_DONTWAIT, NULL, 0);
91+
printf("sendto(%d, {len=%u, type=CRYPTO_MSG_UPDATEALG"
8492
", flags=%#x /* NLM_F_??? */, seq=0, pid=0}"
8593
", %u, MSG_DONTWAIT, NULL, 0) = %s\n",
8694
fd, nlh.nlmsg_len, NLM_F_REPLACE,

‎tests/netlink_route.c

+3-4
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,12 @@ test_nlmsg_flags(const int fd)
132132
fd, nlh.nlmsg_len, (unsigned) sizeof(nlh), sprintrc(rc));
133133

134134
nlh.nlmsg_type = RTM_DELLINK;
135-
nlh.nlmsg_flags = NLM_F_REPLACE;
135+
nlh.nlmsg_flags = NLM_F_NONREC;
136136
rc = sendto(fd, &nlh, sizeof(nlh), MSG_DONTWAIT, NULL, 0);
137137
printf("sendto(%d, {len=%u, type=RTM_DELLINK"
138-
", flags=%#x /* NLM_F_??? */, seq=0, pid=0}"
138+
", flags=NLM_F_NONREC, seq=0, pid=0}"
139139
", %u, MSG_DONTWAIT, NULL, 0) = %s\n",
140-
fd, nlh.nlmsg_len, NLM_F_REPLACE,
141-
(unsigned) sizeof(nlh), sprintrc(rc));
140+
fd, nlh.nlmsg_len, (unsigned) sizeof(nlh), sprintrc(rc));
142141
}
143142

144143
static void

‎tests/netlink_xfrm.c

+9-1
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,17 @@ test_nlmsg_flags(const int fd)
7676
fd, nlh.nlmsg_len, (unsigned) sizeof(nlh), sprintrc(rc));
7777

7878
nlh.nlmsg_type = XFRM_MSG_DELSA;
79-
nlh.nlmsg_flags = NLM_F_ECHO | NLM_F_REPLACE;
79+
nlh.nlmsg_flags = NLM_F_ECHO | NLM_F_NONREC;
8080
rc = sendto(fd, &nlh, sizeof(nlh), MSG_DONTWAIT, NULL, 0);
8181
printf("sendto(%d, {len=%u, type=XFRM_MSG_DELSA"
82+
", flags=NLM_F_ECHO|NLM_F_NONREC, seq=0, pid=0}"
83+
", %u, MSG_DONTWAIT, NULL, 0) = %s\n",
84+
fd, nlh.nlmsg_len, (unsigned) sizeof(nlh), sprintrc(rc));
85+
86+
nlh.nlmsg_type = XFRM_MSG_ALLOCSPI;
87+
nlh.nlmsg_flags = NLM_F_ECHO | NLM_F_REPLACE;
88+
rc = sendto(fd, &nlh, sizeof(nlh), MSG_DONTWAIT, NULL, 0);
89+
printf("sendto(%d, {len=%u, type=XFRM_MSG_ALLOCSPI"
8290
", flags=NLM_F_ECHO|%#x, seq=0, pid=0}"
8391
", %u, MSG_DONTWAIT, NULL, 0) = %s\n",
8492
fd, nlh.nlmsg_len, NLM_F_REPLACE,

‎xlat/netlink_delete_flags.in

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
NLM_F_NONREC

0 commit comments

Comments
 (0)
Please sign in to comment.