Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharer not closing when losing focus #27

Open
reneroth opened this issue Oct 1, 2015 · 1 comment
Open

Sharer not closing when losing focus #27

reneroth opened this issue Oct 1, 2015 · 1 comment

Comments

@reneroth
Copy link

reneroth commented Oct 1, 2015

The sharer only closes if you click on a targeted element, not if the selection loses focus by clicking on an element that is not targeted by selection-sharer.

As a fix, I use:

if(!window.getSelection().length) {
    self.hide();
    return;
}

in this.selectionChanged, line 311, before checking self.isMobile.

@Ecnelis
Copy link

Ecnelis commented May 16, 2017

This fix doesn't seem to work anymore. Is there any onther way to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants