Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Complete overhaul / rewrite #84

Merged
merged 38 commits into from
Aug 29, 2023
Merged

V2: Complete overhaul / rewrite #84

merged 38 commits into from
Aug 29, 2023

Conversation

xTVaser
Copy link
Owner

@xTVaser xTVaser commented Aug 29, 2023

Primary motivator was to switch to twitch's configuration service, which they did not offer at the time the original extension was made. That meant hosting my own server which is an annoying cost + maintenance burden that frequently has downtime. This meant dealing with the code that was thrown together as fast as possible almost 5 years ago -- a rewrite was much easier way to go. Notable changes besides the lack of a backend:

  • actually wrote tests this time
  • using a sane framework instead of jquery
  • significantly fewer calls to speedrun.com -- though ironically this can perform worse than making hundreds of individual calls due to performance issues on their end.

they only accept URLs, can't add `data:` to it.
@xTVaser xTVaser mentioned this pull request Aug 29, 2023
@xTVaser xTVaser merged commit d08010c into master Aug 29, 2023
3 checks passed
@xTVaser xTVaser deleted the v2 branch August 29, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant